This repository was archived by the owner on Aug 31, 2021. It is now read-only.
[[ CEF ]] Change libcef relative path on Windows#104
Merged
livecodepanos merged 1 commit intodevelopfrom Jun 14, 2017
Merged
Conversation
This patch ensures that the path (relative to the exe) which is used for 'libcef.dll' is Externals/CEF. This ensures that (when built) all engines look for things in the same place. Note: This will break CEF when building from source - we need to update the 'bin' folder structure appropriately on Windows.
Contributor
|
@livecode-vulcan review ok 152ee7f |
|
💙 review by @livecodepanos ok 152ee7f |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This patch ensures that the path (relative to the exe) which is
used for 'libcef.dll' is Externals/CEF.
This ensures that (when built) all engines look for things in the
same place.
Note: This will break CEF when building from source - we need to
update the 'bin' folder structure appropriately on Windows.